Kafka 3078#747
Conversation
…SL enabled Kafka cluster
There was a problem hiding this comment.
Not a big deal, but for future reference doing something like if self.security_protocol in [SecurityConfig.SASL_PLAINTEXT, SecurityConfig.SASL_SSL, SecurityConfig.SASL_MECHANISM_GSSAPI, SecurityConfig.SASL_MECHANISM_PLAIN] is a more concise way to express conditions like this. In fact, it might be valuable to add those collections to SecurityConfig since it would allow for simple tests that look something like if self.security_protocol in SecurityConfig.SASL_MECHANISMS.
|
LGTM. I know you filed the ducktape test as a separate subtask, but in the future if you want to roll the system test update into the same patch, it's actually easier to review together for relatively small patches like this since the system test itself is the best validation of the original patch. |
With 6f81bb1 merged, we can now use c4.xlarge instances with our system tests, which are much more reliable for spot than m3.xlarge.
Note that KAFKA-3077 will be required to run these tests.