KAFKA-8952: Update Jackson to 2.10.0#7411
Merged
Merged
Conversation
ijuma
changed the title
omkreddy
approved these changes
Sep 29, 2019
omkreddy
left a comment
omkreddy
left a comment
Contributor
There was a problem hiding this comment.
@ijuma Thanks for the PR. LGTM.
KAFKA-8952 also mentions guava-20.0.jar. Should we do anything about it?
Its coming from org.reflections:reflections jar.
+--- org.reflections:reflections:0.9.11
| +--- com.google.guava:guava:20.0
Member
Author
|
@omkreddy That one is more complicated since reflections doesn't necessarily work with newer versions of guava: |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Sep 29, 2019
Guava hasn't been upgraded due to potential incompatibility with the reflections library: ronmamo/reflections#194 Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
Member
Author
|
Merging to trunk, 2.3 and 2.2 branches. |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Sep 29, 2019
Guava hasn't been upgraded due to potential incompatibility with the reflections library: ronmamo/reflections#194 Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
|
@ijuma, Thank you for the changes, When can I get the binary for these changes on kafka official site? |
Member
|
@NamrataKokate keep an eye on the mailing list for release announcements. Bugfix releases 2.3.1 and 2.2.2 are currently in progress. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guava hasn't been upgraded due to potential incompatibility with the reflections
library:
ronmamo/reflections#194
Committer Checklist (excluded from commit message)