KAFKA-8421: Still return data during rebalance #7312
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -761,7 +761,11 @@ public boolean refreshCommittedOffsetsIfNeeded(Timer timer) { | |
|
|
||
| log.info("Setting offset for partition {} to the committed offset {}", tp, position); | ||
| entry.getValue().leaderEpoch().ifPresent(epoch -> this.metadata.updateLastSeenEpochIfNewer(entry.getKey(), epoch)); | ||
|
|
||
| // it's possible that the partition is no longer assigned when the response is received, | ||
| // so we need to ignore seeking if that's the case | ||
| if (this.subscriptions.isAssigned(tp)) | ||
|
Contributor
Author
There was a problem hiding this comment. @hachikuji This is the change I make for auto offset reset. I thought about adding a unit test but since the logic is wrapped in a single
Contributor
There was a problem hiding this comment. Does it make sense to move this check above a little bit? if (offsetAndMetadata != null && subscriptions.isAssigned(tp)) {That will make the log message less confusing.
Contributor
Author
There was a problem hiding this comment. Hmm, but I thought even if the partition is no longer assigned, we may still want to update its epoch; on the other hand your concern is valid. Will tweak it a bit more. |
||
| this.subscriptions.seekUnvalidated(tp, position); | ||
| } | ||
| } | ||
| return true; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth adding a debug message saying that we're ignoring the fetched offset?