KAFKA-8861 Fix flaky RegexSourceIntegrationTest.testMultipleConsumers…#7281
Merged
Conversation
…CanReadFromPartitionedTopic
mjsax
approved these changes
Sep 3, 2019
mjsax
left a comment
mjsax
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! LGTM.
Call for second review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna @abbccdda
Member
|
Java 11 / 2.12 failed with env error. Java 11 / 2.13 and Java 8 passed. Retest this please. |
Member
|
Older branches are affected, too. The first fix (for same issue, different methods) when into 2.0 (but not 1.1) -- hence, we should only back-port to |
Member
|
retest this please |
Member
|
Why did we need to retest, @bbejeck ? |
3 tasks
Member
|
Merged #7281 into trunk. |
bbejeck
pushed a commit
that referenced
this pull request
Sep 4, 2019
…CanReadFromPartitionedTopic (#7281) similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026 Reviewers: Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Sep 4, 2019
…CanReadFromPartitionedTopic (#7281) similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026 Reviewers: Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Sep 4, 2019
…CanReadFromPartitionedTopic (#7281) similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026 Reviewers: Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Sep 4, 2019
…CanReadFromPartitionedTopic (#7281) similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026 Reviewers: Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@gmail.com>
Member
|
cherry-picked to 2.3, 2.2, 2.1 and 2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026
Committer Checklist (excluded from commit message)