MINOR: Eliminate unnecessary map operations in RecordAccumulator.isMuted#7193
Merged
Merged
Conversation
ijuma
reviewed
Aug 11, 2019
ijuma
reviewed
Aug 11, 2019
ijuma
approved these changes
Aug 11, 2019
ijuma
left a comment
ijuma
left a comment
Member
There was a problem hiding this comment.
LGTM. Worth adding a comment explaining that this method is perf sensitive when there are a large number of partitions.
Member
|
One unrelated test failure in one job and 2 jobs that timed out. |
Member
|
retest this please |
ijuma
changed the title
Member
|
I updated the PR description as the changes could reduce the look-ups from 3 to 1 in the case where the partition is unmuted. |
ijuma
changed the title
Member
|
Two jobs passed, one failed with flake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids calling both
containsKeyandgetfrom isMuted, when only a single get is necessary.Also avoid calling
removeunless necessary. This could be a reduction of map operationsfrom 3 to 1.
isMuted showed up as a hotspot in profiling when using the producer with high numbers of partitions.