KAFKA-8782: Close metrics in QuotaManagerTests#7191
Merged
Conversation
omkreddy
approved these changes
Aug 11, 2019
Contributor
There was a problem hiding this comment.
unused import checkstyle error.
Member
Author
There was a problem hiding this comment.
Thanks, I had forgotten to push the updated branch after I fixed this.
ijuma
force-pushed
the
close-metrics-in-quota-manager-test
branch
from
August 11, 2019 18:40
a017572 to
3ebc52b
Compare
Member
Author
|
Two jobs passed, one failed with known flake Merging to trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
Metricswas constructed withenableExpiration=false, this wasnot a source of flakiness given the current implementation. This could
change in the future, so good to follow the class contract.
Included a few clean-ups with regards to redundant casts and type parameters
as well as usage of try with resources for inline usage of
Metrics.Committer Checklist (excluded from commit message)