Skip to content

MINOR: Avoid dividing by zero #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 1 commit into from
Aug 3, 2019
Merged

MINOR: Avoid dividing by zero #7143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,15 +1042,15 @@ private boolean maybePunctuate() {
* or if the task producer got fenced (EOS)
*/
boolean maybeCommit() {
int committed = 0;
final int committed;

if (now - lastCommitMs > commitTimeMs) {
if (log.isTraceEnabled()) {
log.trace("Committing all active tasks {} and standby tasks {} since {}ms has elapsed (commit interval is {}ms)",
taskManager.activeTaskIds(), taskManager.standbyTaskIds(), now - lastCommitMs, commitTimeMs);
}

committed += taskManager.commitAll();
committed = taskManager.commitAll();
if (committed > 0) {
final long intervalCommitLatency = advanceNowAndComputeLatency();
commitSensor.record(intervalCommitLatency / (double) committed, now);
Expand All @@ -1067,11 +1067,10 @@ boolean maybeCommit() {
lastCommitMs = now;
processStandbyRecords = true;
} else {
final int commitPerRequested = taskManager.maybeCommitActiveTasksPerUserRequested();
if (commitPerRequested > 0) {
committed = taskManager.maybeCommitActiveTasksPerUserRequested();
if (committed > 0) {
final long requestCommitLatency = advanceNowAndComputeLatency();
commitSensor.record(requestCommitLatency / (double) committed, now);

@mjsax mjsax Aug 1, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was here: committed could be zero without this fix.

@ableegoldman ableegoldman Aug 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should have noticeably screwed up these metrics, do we think this branch is just rarely seen or no one has noticed somehow?

@mjsax mjsax Aug 1, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's rarely executed. Only if a PAPI user request committing via context.commit(), what is expected to be rarely used feature.

committed += commitPerRequested;
}
}

Expand Down