MINOR: Fix Streams metadata upgrade system test#7118
Merged
Conversation
- broke because of ZK version bump
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna @abbccdda |
Member
Author
|
Triggered Streams system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2833/ |
Member
Author
|
Set incorrect ZK version for 0.10.1 (thought both would be the same). Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2835/ |
ableegoldman
approved these changes
Jul 28, 2019
ableegoldman
left a comment
ableegoldman
left a comment
Member
There was a problem hiding this comment.
System tests passed, thanks Matthias!
guozhangwang
approved these changes
Jul 29, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent ZK version bump broke the system test.
Kafka Streams depends on ZK in version 0.10.0 and 0.10.1. Previously, when running the system test we got the dependency added to the class path from the broker dependencies. With the ZK version bump, incorrect dependencies were added, resulting in class loading errors.
In this PR, we (1) remove core dependencies completely for the case we run an upgrade test, because Streams does not need those dependencies anyway. (2) For the case of running the upgrade test, we add the correct jars to the class path for 0.10.0 and 0.10.1 versions.