Skip to content

MINOR: some small style fixes to RoundRobinPartitioner#7058

Closed
cmccabe wants to merge 1 commit into
apache:trunkfrom
cmccabe:rr-style-fixes
Closed

MINOR: some small style fixes to RoundRobinPartitioner#7058
cmccabe wants to merge 1 commit into
apache:trunkfrom
cmccabe:rr-style-fixes

Conversation

@cmccabe

@cmccabe cmccabe commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@cmccabe

cmccabe commented Jul 9, 2019

Copy link
Copy Markdown
Contributor Author
  • Use @Override annotation where appropriate
  • Avoid using typecasts where they aren't needed
  • Move some variables that are only used in a single test case into that test case
  • Make some test fields static and final where appropriate

@cmccabe

cmccabe commented Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

1 similar comment
@cmccabe

cmccabe commented Jul 12, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

@gwenshap gwenshap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@gwenshap gwenshap closed this in e4e2dd3 Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants