KAFKA-6263: Expose metrics for group and transaction metadata loading duration#7045
Closed
anatasiavela wants to merge 9 commits into
Closed
KAFKA-6263: Expose metrics for group and transaction metadata loading duration#7045anatasiavela wants to merge 9 commits into
anatasiavela wants to merge 9 commits into
Conversation
Contributor
|
Can you also update the metrics documentation with these new metrics? They are at https://github.com/apache/kafka/blob/trunk/docs/ops.html |
apovzner
reviewed
Jul 30, 2019
apovzner
reviewed
Jul 30, 2019
apovzner
reviewed
Jul 30, 2019
gwenshap
requested changes
Jul 31, 2019
gwenshap
left a comment
gwenshap
left a comment
Contributor
There was a problem hiding this comment.
The metrics look good, but the test should be simpler and shorter. I gave some suggestions.
hachikuji
reviewed
Aug 1, 2019
hachikuji
left a comment
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
@anatasiavela Thanks for the contribution! I just had a few nitpicks.
gwenshap
reviewed
Aug 1, 2019
| val reporter = new JmxReporter("kafka.server") | ||
| metrics.addReporter(reporter) | ||
|
|
||
| def partitionLoadTime(attribute: String): Double = { |
gwenshap
approved these changes
Aug 1, 2019
gwenshap
left a comment
gwenshap
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I'll wait for tests to pass before merging.
hachikuji
approved these changes
Aug 1, 2019
hachikuji
left a comment
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! LGTM
Contributor
|
retest this please |
Contributor
|
ok, passed enough. Merging. Thank you for contributing, Anastasia! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
Committer Checklist (excluded from commit message)