Skip to content

KAFKA-8618: Replace Txn marker with automated protocol#7039

Merged
mimaison merged 2 commits into
apache:trunkfrom
abbccdda:txn_marker
Mar 19, 2020
Merged

KAFKA-8618: Replace Txn marker with automated protocol#7039
mimaison merged 2 commits into
apache:trunkfrom
abbccdda:txn_marker

Conversation

@abbccdda

@abbccdda abbccdda commented Jul 7, 2019

Copy link
Copy Markdown

As title. This one is tricky because the original txn marker entry has been widely used, so we choose to minimize the change by making the transformation internal for the txn marker class.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@abbccdda
abbccdda force-pushed the txn_marker branch 3 times, most recently from b629f53 to 7ab4850 Compare January 10, 2020 17:14
@hachikuji

hachikuji commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

retest this please

1 similar comment
@hachikuji

hachikuji commented Jan 30, 2020

Copy link
Copy Markdown
Contributor

retest this please

@abbccdda

abbccdda commented Jan 30, 2020

Copy link
Copy Markdown
Author

Checked both test failures are flaky

@hachikuji

hachikuji commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

retest this please

1 similar comment
@abbccdda

abbccdda commented Feb 6, 2020

Copy link
Copy Markdown
Author

retest this please

@hachikuji

hachikuji commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

ok to test

@guozhangwang

guozhangwang commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

retest this please

@guozhangwang

guozhangwang commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

test this please

@abbccdda

abbccdda commented Feb 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Got 1/2 green build https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/4641/
The two failure test cases for the other build are flaky ones:
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/628/

@abbccdda

abbccdda commented Mar 13, 2020

Copy link
Copy Markdown
Author

@mimaison Hey Mickael, could you take a look of this PR?

mimaison
mimaison requested changes Mar 13, 2020
View reviewed changes

@mimaison mimaison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abbccdda
I've made a quick pass and left a few small comments

Comment thread clients/src/main/java/org/apache/kafka/common/requests/WriteTxnMarkersResponse.java Outdated
Comment thread clients/src/test/java/org/apache/kafka/common/requests/WriteTxnMarkersRequestTest.java Outdated
Comment thread clients/src/test/java/org/apache/kafka/common/requests/WriteTxnMarkersResponseTest.java Outdated
Comment thread clients/src/main/java/org/apache/kafka/common/requests/WriteTxnMarkersRequest.java Outdated
@abbccdda

abbccdda commented Mar 14, 2020

Copy link
Copy Markdown
Author

@mimaison Thanks for the review, addressed.

@mimaison

mimaison commented Mar 15, 2020

Copy link
Copy Markdown
Member

retest this please

1 similar comment
@mimaison

mimaison commented Mar 15, 2020

Copy link
Copy Markdown
Member

retest this please

@abbccdda

abbccdda commented Mar 16, 2020

Copy link
Copy Markdown
Author

@mimaison Could you help trigger another test?

@mimaison

mimaison commented Mar 16, 2020

Copy link
Copy Markdown
Member

retest this please

@abbccdda

abbccdda commented Mar 16, 2020

Copy link
Copy Markdown
Author

@mimaison Looks like the Jenkins jobs are killed, mind kicking off another one?

@mimaison

mimaison commented Mar 16, 2020

Copy link
Copy Markdown
Member

retest this please

@abbccdda

abbccdda commented Mar 17, 2020

Copy link
Copy Markdown
Author

@mimaison Do you mind triggering another test? The PR was rebased to include two broken unit test changes landed yesterday.

@guozhangwang

guozhangwang commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

test this please

2 similar comments
@guozhangwang

guozhangwang commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

test this please

@guozhangwang

guozhangwang commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

test this please

@abbccdda

abbccdda commented Mar 17, 2020

Copy link
Copy Markdown
Author

Looks like the test was flaky and not related: org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldReturnEmptyArrayIfListFilesReturnsNull
Which is actively being fixed: #8310

@mimaison Let me know if you think we should kick off another test just for sanity

@mimaison

mimaison commented Mar 17, 2020

Copy link
Copy Markdown
Member

Thanks for thr updates @abbccdda. I plan to take another look this week

@abbccdda

abbccdda commented Mar 18, 2020

Copy link
Copy Markdown
Author

Rebased

@mimaison

mimaison commented Mar 19, 2020

Copy link
Copy Markdown
Member

retest this please

@mimaison
mimaison merged commit c7164a3 into apache:trunk Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimaison mimaison mimaison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abbccdda @hachikuji @guozhangwang @mimaison