Skip to content

KAFKA-8598: Use automatic RPC generation in RenewDelegationToken#7038

Closed
mimaison wants to merge 1 commit into
apache:trunkfrom
mimaison:KAFKA-8598
Closed

KAFKA-8598: Use automatic RPC generation in RenewDelegationToken#7038
mimaison wants to merge 1 commit into
apache:trunkfrom
mimaison:KAFKA-8598

Conversation

@mimaison

@mimaison mimaison commented Jul 5, 2019

Copy link
Copy Markdown
Member

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mimaison

mimaison commented Jul 6, 2019

Copy link
Copy Markdown
Member Author

Retest this please

@mimaison

Copy link
Copy Markdown
Member Author

Retest this please

@mimaison

Copy link
Copy Markdown
Member Author

@abbccdda @cmccabe Can you take a look?

@mimaison

Copy link
Copy Markdown
Member Author

ping @abbccdda @cmccabe

@viktorsomogyi viktorsomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although the test results have already been removed so I couldn't look at the few failed tests.

@mimaison

mimaison commented Aug 5, 2019

Copy link
Copy Markdown
Member Author

@omkreddy Can you have a look?

@omkreddy

omkreddy commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

@mimaison I will review both the PRs. Thanks.

@omkreddy

omkreddy commented Aug 7, 2019

Copy link
Copy Markdown
Contributor

@mimaison Can you please rebase the PR?

@mimaison

mimaison commented Aug 7, 2019

Copy link
Copy Markdown
Member Author

@omkreddy I've rebased on trunk

@omkreddy

omkreddy commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

retest this please

@omkreddy omkreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimaison Thanks for the PR. LGTM.

@omkreddy

omkreddy commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

retest this please

@omkreddy omkreddy closed this in 5e543ae Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants