Skip to content

MINOR: Disable scoverage in 2.0 #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 1 commit into from
Jun 21, 2019
Merged

MINOR: Disable scoverage in 2.0 #6980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ buildscript {
// For Apache Rat plugin to ignore non-Git files
classpath "org.ajoberstar:grgit:1.9.3"
classpath 'com.github.ben-manes:gradle-versions-plugin:0.17.0'
classpath 'org.scoverage:gradle-scoverage:2.3.0'
classpath 'com.github.jengelman.gradle.plugins:shadow:2.0.4'
classpath 'org.owasp:dependency-check-gradle:3.1.2'
classpath "com.diffplug.spotless:spotless-plugin-gradle:3.10.0"
Expand Down Expand Up @@ -402,13 +401,12 @@ subprojects {
}
}

def coverageGen = it.path == ':core' ? 'reportScoverage' : 'jacocoTestReport'
task reportCoverage(dependsOn: [coverageGen])

def coverageGen = it.path == ':core' ? [] : ['jacocoTestReport']
task reportCoverage(dependsOn: coverageGen)
}

gradle.taskGraph.whenReady { taskGraph ->
taskGraph.getAllTasks().findAll { it.name.contains('findbugsScoverage') || it.name.contains('findbugsTest') }.each { task ->
taskGraph.getAllTasks().findAll { it.name.contains('findbugsTest') }.each { task ->
task.enabled = false
}
}
Expand Down Expand Up @@ -544,7 +542,6 @@ project(':core') {
println "Building project 'core' with Scala version ${versions.scala}"

apply plugin: 'scala'
apply plugin: "org.scoverage"
archivesBaseName = "kafka_${versions.baseScala}"

dependencies {
Expand Down Expand Up @@ -586,20 +583,8 @@ project(':core') {
testCompile libs.scalatest
testCompile libs.slf4jlog4j
testCompile libs.jfreechart

scoverage libs.scoveragePlugin
scoverage libs.scoverageRuntime
}

scoverage {
reportDir = file("${rootProject.buildDir}/scoverage")
highlighting = false
}
checkScoverage {
minimumRate = 0.0
}
checkScoverage.shouldRunAfter('test')

configurations {
// manually excludes some unnecessary dependencies
compile.exclude module: 'javax'
Expand Down