MINOR: Account for different versions in upgrade#6835
Conversation
|
Kicked off branch builder for |
|
branch builder for metadata-upgrade-test passed branch builder for entire-upgrade-system-test passed |
|
Java 11 failed retest this please |
| # checking for the dev version which should be the only SNAPSHOT | ||
| log_monitor.wait_until("Kafka version.*-SNAPSHOT", | ||
| timeout_sec=60, | ||
| err_msg="Could not detect Kafka Streams version " + str(DEV_VERSION) + " in " + str(node.account)) |
There was a problem hiding this comment.
Shouldn't str(DEV_VERSION) in the error message also be changed?
There was a problem hiding this comment.
I wanted to leave the str(DEV_VERSION) as is so it's more clear in the logs if an error occurs
|
updated to be more strict on the version number expected
UPDATE: All branch builders passed |
|
Merged #6835 into trunk |
Reviewers: Guozhang Wang <wangguoz@gmail.com>, Bruno Cadonna <bruno@confluent.io>
|
cherry-picked #6835 to 2.3 |
Reviewers: Guozhang Wang <wangguoz@gmail.com>, Bruno Cadonna <bruno@confluent.io>
3 participants
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)