MINOR: Fix transient failure in PartitionTest.testAddAndRemoveMetrics#6834
Merged
Merged
Conversation
ijuma
approved these changes
May 28, 2019
ijuma
left a comment
ijuma
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, LGTM. We should probably cherry-pick to 2.3 too.
Member
|
JDK 11 passed, JDK 8 had two flakes:
|
Member
|
retest this please |
Contributor
Author
|
@ijuma Actually it's not needed in 2.3 since the failing test was not merged there |
Member
|
Good to know, thanks. |
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
…apache#6834) The test was failing because other test cases are leaving some metrics in the registry. This patch cleans the registry before and after test runs. Reviewers: Ismael Juma <ismael@juma.me.uk>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…apache#6834) The test was failing because other test cases are leaving some metrics in the registry. This patch cleans the registry before and after test runs. Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is failing because other test cases are leaving some metrics in the registry. This patch cleans the registry before and after test runs.
Committer Checklist (excluded from commit message)