Skip to content

MINOR: Add tests to verify setting of serdes in timestamped key-value store #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbejeck merged 2 commits into from
May 29, 2019
Merged

MINOR: Add tests to verify setting of serdes in timestamped key-value store #6825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
099a81e
MINOR: Add unit tests to verify setting of serdes in timestamped key-…
cadonna May 27, 2019
02debe8
Merge remote-tracking branch 'upstream/trunk' into add_serdes_unit_tests
cadonna May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions ...st/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
import org.apache.kafka.common.metrics.KafkaMetric;
import org.apache.kafka.common.metrics.Metrics;
import org.apache.kafka.common.metrics.Sensor;
import org.apache.kafka.common.serialization.Serde;
import org.apache.kafka.common.serialization.Serdes;
import org.apache.kafka.common.utils.Bytes;
import org.apache.kafka.common.utils.MockTime;
import org.apache.kafka.streams.KeyValue;
import org.apache.kafka.streams.errors.StreamsException;
import org.apache.kafka.streams.processor.ProcessorContext;
import org.apache.kafka.streams.processor.TaskId;
import org.apache.kafka.streams.processor.internals.MockStreamsMetrics;
Expand Down Expand Up @@ -57,6 +59,7 @@
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

@RunWith(EasyMockRunner.class)
public class MeteredTimestampedKeyValueStoreTest {
Expand Down Expand Up @@ -254,4 +257,53 @@ private KafkaMetric metric(final MetricName metricName) {
return this.metrics.metric(metricName);
}

@Test
@SuppressWarnings("unchecked")
public void shouldNotThrowExceptionIfSerdesCorrectlySetFromProcessorContext() {
expect(context.keySerde()).andStubReturn((Serde) Serdes.String());
expect(context.valueSerde()).andStubReturn((Serde) Serdes.Long());
final MeteredTimestampedKeyValueStore<String, Long> store = new MeteredTimestampedKeyValueStore<>(
inner,
"scope",
new MockTime(),
null,
null
);
replay(inner, context);
store.init(context, inner);

try {
store.put("key", ValueAndTimestamp.make(42L, 60000));
} catch (final StreamsException exception) {
if (exception.getCause() instanceof ClassCastException) {
fail("Serdes are not correctly set from processor context.");
}
throw exception;
}
}

@Test
@SuppressWarnings("unchecked")
public void shouldNotThrowExceptionIfSerdesCorrectlySetFromConstructorParameters() {
expect(context.keySerde()).andStubReturn((Serde) Serdes.String());
expect(context.valueSerde()).andStubReturn((Serde) Serdes.Long());
final MeteredTimestampedKeyValueStore<String, Long> store = new MeteredTimestampedKeyValueStore<>(
inner,
"scope",
new MockTime(),
Serdes.String(),
new ValueAndTimestampSerde<>(Serdes.Long())
);
replay(inner, context);
store.init(context, inner);

try {
store.put("key", ValueAndTimestamp.make(42L, 60000));
} catch (final StreamsException exception) {
if (exception.getCause() instanceof ClassCastException) {
fail("Serdes are not correctly set from constructor parameters.");
}
throw exception;
}
}
}