MINOR: Auth operations must be null when talking to a pre-KIP-430 broker#6812
Merged
Conversation
cmccabe
force-pushed
the
fix-kip-430-api
branch
2 times, most recently
from
May 24, 2019 22:39
d40efca to
080705b
Compare
…30 broker. Authorized operations must be null when talking to a pre-KIP-430 broker. If we present this as the empty set instead, it is impossible for clients to know if they have no permissions, or are talking to an old broker.
omkreddy
reviewed
May 25, 2019
Contributor
There was a problem hiding this comment.
we should also update DescribeGroupsResponse.json.
Member
There was a problem hiding this comment.
@omkreddy Colin is away for a week or so, so maybe you can address this when you have a chance. This is a blocker for 2.3.
asfgit
pushed a commit
that referenced
this pull request
May 28, 2019
…ker (#6812) Authorized operations must be null when talking to a pre-KIP-430 broker. If we present this as the empty set instead, it is impossible for clients to know if they have no permissions, or are talking to an old broker. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
Contributor
Author
|
Committed to 2.3. @omkreddy, can you post the follow-up with the change to |
2 tasks
Contributor
|
@cmccabe I have already pushed my changes to this PR. sorry for not commenting earlier. |
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
…ker (apache#6812) Authorized operations must be null when talking to a pre-KIP-430 broker. If we present this as the empty set instead, it is impossible for clients to know if they have no permissions, or are talking to an old broker. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ker (apache#6812) Authorized operations must be null when talking to a pre-KIP-430 broker. If we present this as the empty set instead, it is impossible for clients to know if they have no permissions, or are talking to an old broker. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authorized operations must be null when talking to a pre-KIP-430 broker. If we present this as the empty set instead, it is impossible for clients to know if they have no permissions, or are talking to an old broker.