Skip to content

MINOR: Fix a toString npe in tableProcessorNode#6807

Merged
ijuma merged 2 commits into
apache:trunkfrom
rodesai:fix-npe-table-processor-node
May 25, 2019
Merged

MINOR: Fix a toString npe in tableProcessorNode#6807
ijuma merged 2 commits into
apache:trunkfrom
rodesai:fix-npe-table-processor-node

Conversation

@rodesai

@rodesai rodesai commented May 24, 2019

Copy link
Copy Markdown
Contributor

Fix a toString npe in tableProcessorNode. This gets hit when we run
KSQL with debug logging enabled.

@ijuma

ijuma commented May 24, 2019

Copy link
Copy Markdown
Member

Worth adding a unit test.

@rodesai

rodesai commented May 24, 2019

Copy link
Copy Markdown
Contributor Author

Fair enough

@rodesai
rodesai force-pushed the fix-npe-table-processor-node branch 2 times, most recently from c12512e to fc7f17a Compare May 24, 2019 08:02
@guozhangwang

Copy link
Copy Markdown
Contributor

checkstyle seems not happy.

@guozhangwang guozhangwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, lgtm.

@ijuma

ijuma commented May 24, 2019

Copy link
Copy Markdown
Member

Also, the target branch should be trunk. The committer will cherry-pick to 2.3 as well.

@bbejeck bbejeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodesai! LGTM modulo checkstyle

@rodesai
rodesai force-pushed the fix-npe-table-processor-node branch from fc7f17a to 11e7518 Compare May 24, 2019 17:28
@rodesai
rodesai changed the base branch from 2.3 to trunk May 24, 2019 17:29
@ijuma

ijuma commented May 25, 2019

Copy link
Copy Markdown
Member

JDK 11 build passed, JDK 8 build failed with flaky and unrelated PartitionTest.testAddAndRemoveMetrics.

@ijuma ijuma changed the title Fix a toString npe in tableProcessorNode MINOR: Fix a toString npe in tableProcessorNode May 25, 2019
@ijuma
ijuma merged commit 5ecac84 into apache:trunk May 25, 2019
ijuma pushed a commit that referenced this pull request May 25, 2019
This gets hit when debug logging is enabled.

Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
@ijuma

ijuma commented May 25, 2019

Copy link
Copy Markdown
Member

Merged to trunk and 2.3 branches.

haidangdam pushed a commit to haidangdam/kafka that referenced this pull request May 29, 2019
This gets hit when debug logging is enabled.

Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
This gets hit when debug logging is enabled.

Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants