[MINOR] Improve docs for Global Store operations#6803
Merged
Conversation
Member
Author
mjsax
reviewed
May 24, 2019
| * <p> | ||
| * The provided {@link ProcessorSupplier} will be used to create an {@link ProcessorNode} that will receive all | ||
| * records forwarded from the {@link SourceNode}. | ||
| * records forwarded from the {@link SourceNode}. NOTE: you should not use this to insert transformed records into |
Member
There was a problem hiding this comment.
nit: remove use this to
Or use the {@code Processor} to
mjsax
approved these changes
May 24, 2019
cadonna
approved these changes
May 28, 2019
Member
|
Retest this, please |
Member
|
retest this please |
Member
Author
|
Do we really need a green build for this? It's just docs... |
Member
|
Merged #6803 to trunk |
bbejeck
pushed a commit
that referenced
this pull request
May 30, 2019
A lot of confusion seems to have arisen from the StreamBuilder#addGlobalStore(...ProcessorSupplier) method. Users have assumed they can safely use this to transform records before populating their global state store; unfortunately this results in corrupted data as on restore the records are read directly from the source topic changelog, bypassing their custom processor. We should probably provide a means to do this at some point but for the time being we should clarify the proper use of #addGlobalStore as it currently functions Reviewers: Matthias J. Sax <mjsax@apache.org>, Bruno Cadonna <bruno@confluent.io>
Member
|
cherry-picked to 2.3 |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
A lot of confusion seems to have arisen from the StreamBuilder#addGlobalStore(...ProcessorSupplier) method. Users have assumed they can safely use this to transform records before populating their global state store; unfortunately this results in corrupted data as on restore the records are read directly from the source topic changelog, bypassing their custom processor. We should probably provide a means to do this at some point but for the time being we should clarify the proper use of #addGlobalStore as it currently functions Reviewers: Matthias J. Sax <mjsax@apache.org>, Bruno Cadonna <bruno@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of confusion seems to have arisen from the StreamBuilder#addGlobalStore(...ProcessorSupplier) method. Users have assumed they can safely use this to transform records before populating their global state store; unfortunately this results in corrupted data as on restore the records are read directly from the source topic changelog, bypassing their custom processor.
We should probably provide a means to do this at some point but for the time being we should clarify the proper use of #addGlobalStore as it currently functions