KAFKA-8219: add doc changes for static membership release#6790
Conversation
|
@guozhangwang @hachikuji @mjsax Let me know if there is anything missing. Thank you! |
|
Retest this please |
1 similar comment
|
Retest this please |
|
work? |
There was a problem hiding this comment.
KStream is not the standard term we recommend to call here. We should just use Kafka Streams or Streams API.
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
My comments on Streams upgrade docs also apply to the main docs -- just did not add them twice.
For the things, that I marked as "do we need this", it might be better to add a proper section about static group membership and explain how it works. And we could link to this section. In future versions, people won't read older release notes and thus this information get buried -- having a proper section about static group membership avoid this issue.
There was a problem hiding this comment.
We should use KStream only to refer to a stream (ie, KStream vs KTable) and use Kafka Streams otherwise to avoid confusion.
There was a problem hiding this comment.
membership, [it is required] to upgrade your Kafka cluster (i.e., brokers) and your Kafka Streams application to 2.3.0.
There was a problem hiding this comment.
Do we need to include This involves a necessity to change <code>inter.broker.protocol.version</code> to 2.3 as well. -- Maybe just link to the main upgrade section instead?
There was a problem hiding this comment.
I guess declaring the requirement here is important to make sure user won't choose to only upgrade one broker for coordinator as a shortcut.
There was a problem hiding this comment.
Yes, but this information is in the broker upgrade section already -- it seems better to not scatter information, but link to the corresponding upgrade sections? Or maybe I am missing your point?
There was a problem hiding this comment.
Then you need to set the config -> You also need to set the config
There was a problem hiding this comment.
We need it for user to trouble shooting when they set group.instance.id on client where broker doesn't support.
There was a problem hiding this comment.
Yes, but as mentioned below, I would prefer to have this information is a proper "static group membership" sections. Having it in the upgrade guide does not seem to be the best place.
There was a problem hiding this comment.
We need to document the expected mechanism for dealing with duplicate instance id case.
|
Working on a central page for static membership. |
4099ce1 to
049312b
Compare
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the update! I like the new section a lot!
There was a problem hiding this comment.
Maybe add one bullet point for Streams:
<li>For Kafka Streams applications, it is sufficient to set a unique <code>ConsumerConfig#GROUP_INSTANCE_ID_CONFIG</code> per KafkaStreams instance, independent of the number of used threads for an instance.</li>
Side question: what happens if one set's the config for a consumer with no group.id -- this case could easily happen for Kafka Streams restore and global consumer?
There was a problem hiding this comment.
@mjsax Static membership only affects group based consumer app. Standalone consumers are not affected (I.E. we won't assign them group.instance.id
There was a problem hiding this comment.
Let me rephrase: What happens if a user configures no group.id but does configure group.instance.id. Do the consumer crash? Or is the group.instance.id config just ignored?
There was a problem hiding this comment.
My understanding is that these two configs should not affect each other. But will try to add a unit test to check.
|
@guozhangwang Could you take another look? |
* add doc changes for static membership release * address comments * address comments for a separate page * address Matthias' comment
|
Cherry-picked to 2.3 as well. |
* add doc changes for static membership release * address comments * address comments for a separate page * address Matthias' comment
* add doc changes for static membership release * address comments * address comments for a separate page * address Matthias' comment
3 participants
This is a doc-change only PR to add upgrade notes for static membership in 2.3