KAFKA-8407: Fix validation of class and list configs in connector client overrides#6789
Merged
Conversation
Contributor
Author
|
@mageshn, since this was introduced by KIP-458 would you mind taking a look? :) |
Contributor
Author
|
@rhauch, could you take a look at this when you have a moment? |
rhauch
approved these changes
May 23, 2019
rhauch
pushed a commit
that referenced
this pull request
May 23, 2019
…ent overrides (#6789) Because of how config values are converted into strings in the `AbstractHerder.validateClientOverrides()` method after being validated by the client override policy, an exception is thrown if the value returned by the policy isn't already parsed as the type expected by the client `ConfigDef`. The fix here involves parsing client override properties before passing them to the override policy. A unit test is added to ensure that several different types of configs are validated properly by the herder. Author: Chris Egerton <chrise@confluent.io> Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Randall Hauch <rhauch@gmail.com>
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
…ent overrides (apache#6789) Because of how config values are converted into strings in the `AbstractHerder.validateClientOverrides()` method after being validated by the client override policy, an exception is thrown if the value returned by the policy isn't already parsed as the type expected by the client `ConfigDef`. The fix here involves parsing client override properties before passing them to the override policy. A unit test is added to ensure that several different types of configs are validated properly by the herder. Author: Chris Egerton <chrise@confluent.io> Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Randall Hauch <rhauch@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ent overrides (apache#6789) Because of how config values are converted into strings in the `AbstractHerder.validateClientOverrides()` method after being validated by the client override policy, an exception is thrown if the value returned by the policy isn't already parsed as the type expected by the client `ConfigDef`. The fix here involves parsing client override properties before passing them to the override policy. A unit test is added to ensure that several different types of configs are validated properly by the herder. Author: Chris Egerton <chrise@confluent.io> Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Randall Hauch <rhauch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Because of how config values are converted into strings in the
AbstractHerder.validateClientOverrides()method after being validated by the client override policy, an exception is thrown if the value returned by the policy isn't already parsed as the type expected by the clientConfigDef. A more thorough writeup of how this happens is available in the linked Jira ticket.The fix here involves parsing client override properties before passing them to the override policy.
A unit test is added to ensure that several different types of configs are validated properly by the herder.
This bug fix should be included in the recently-cut 2.3 branch.
Committer Checklist (excluded from commit message)