MINOR: add Kafka Streams upgrade notes for 2.3 release#6758
Merged
Conversation
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna @abbccdda Tried to cover all KIP for this release. Hope I did not forget anything. |
Member
|
Should we mention upgrading Rocks somewhere? Not an API change exactly but it exposes some new configs |
| For more details please read <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter">KIP-453</a>. | ||
| </p> | ||
|
|
||
| <h3><a id="streams_api_changes_230" href="#streams_api_changes_230">Streams API changes in 2.3.0</a></h3> |
Member
There was a problem hiding this comment.
This was moved to above and should be deleted
| </p> | ||
|
|
||
| <p> | ||
| In previous release, Kafka Streams only shipped with a built-in in-memory key-value store. |
Member
There was a problem hiding this comment.
These are mentioned again below (line 76), you should remove the other comment
Member
Author
|
Updated this. |
vvcephei
approved these changes
May 20, 2019
vvcephei
left a comment
vvcephei
left a comment
Contributor
There was a problem hiding this comment.
A couple of small suggestions. Thanks!
| <p> | ||
| To improve operator semantics, new store types are added that allow storing an additional timestamp per key-value pair or window. | ||
| Some DSL operators (for example KTables) are using those new stores. | ||
| Hence, you can now receive the last update timestamp via Interactive Queries if you change the <code>QueryableStoreType</code>. |
Contributor
There was a problem hiding this comment.
Suggested change
| Hence, you can now receive the last update timestamp via Interactive Queries if you change the <code>QueryableStoreType</code>. | |
| Hence, you can now retrieve the last update timestamp via Interactive Queries if you specify <code>TimestampedWindowStoreType</code> or <code>TimestampedKeyValueStoreType</code>. |
| To improve operator semantics, new store types are added that allow storing an additional timestamp per key-value pair or window. | ||
| Some DSL operators (for example KTables) are using those new stores. | ||
| Hence, you can now receive the last update timestamp via Interactive Queries if you change the <code>QueryableStoreType</code>. | ||
| While this change is mainly transparent to the user, there are some corner cases that may require code changes: |
Contributor
There was a problem hiding this comment.
Maybe a nit, but I feel it's a bit strange to call someone "the user" when you're talking directly to them.
Suggested change
| While this change is mainly transparent to the user, there are some corner cases that may require code changes: | |
| While this change is mainly transparent, there are some corner cases that may require code changes: |
| Some DSL operators (for example KTables) are using those new stores. | ||
| Hence, you can now receive the last update timestamp via Interactive Queries if you change the <code>QueryableStoreType</code>. | ||
| While this change is mainly transparent to the user, there are some corner cases that may require code changes: | ||
| <strong>Caution: If you receive an untyped store and use a cast, you might need to update your code to cast to the correct type.</strong> |
Contributor
There was a problem hiding this comment.
Maybe we can drop in the actual exception, to improve the time-to-discover the reason, if someone is just searching:
java.lang.ClassCastException: class org.apache.kafka.streams.state.ValueAndTimestamp cannot be cast to class ${actual value type} upon getting a value from the store.
Member
Author
|
Updated this. |
bbejeck
approved these changes
May 23, 2019
bbejeck
left a comment
bbejeck
left a comment
Member
There was a problem hiding this comment.
Just one very minor nit, otherwise LGTM
|
|
||
| <p> | ||
| Kafka Streams used to set the configuration parameter <code>max.poll.interval.ms</code> to <code>Interger.MAX_VALUE</code>. | ||
| In default value is removed and Kafka Streams uses the consumer default value now. |
Member
Author
|
Merged to |
mjsax
added a commit
that referenced
this pull request
May 24, 2019
Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, John Roesler <john@confluent.io>, Bill Bejeck <bill@confluent.io>
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, John Roesler <john@confluent.io>, Bill Bejeck <bill@confluent.io>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, John Roesler <john@confluent.io>, Bill Bejeck <bill@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)