Skip to content

KAFKA-8426; Fix for keeping the ConfigProvider configs consistent with KIP-297 #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajinisivaram merged 3 commits into from
Jun 3, 2019
Merged

KAFKA-8426; Fix for keeping the ConfigProvider configs consistent with KIP-297 #6750

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76ceff5
Fix for keeping the ConfigProvider configs consistent with KIP-297
tadsul May 17, 2019
39ac55c
Code Review Fixes
tadsul May 24, 2019
2c80194
Code Review Fixes
tadsul May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ private Map<String, ConfigProvider> instantiateConfigProviders(Map<String, Strin
Map<String, ConfigProvider> configProviderInstances = new HashMap<>();
for (Map.Entry<String, String> entry : providerMap.entrySet()) {
try {
String prefix = CONFIG_PROVIDERS_CONFIG + "." + entry.getKey() + ".";
String prefix = CONFIG_PROVIDERS_CONFIG + "." + entry.getKey() + ".param.";
Comment thread
tadsul marked this conversation as resolved.
Outdated
Map<String, ?> configProperties = configProviderProperties(prefix, providerConfigProperties);
ConfigProvider provider = Utils.newInstance(entry.getValue(), ConfigProvider.class);
provider.configure(configProperties);
Expand Down