KAFKA-8371: Remove dependence on ReplicaManager from Partition#6705
Merged
Conversation
|
Should we consider adding a JIRA for this work? 600+ line of change is non-trivial. |
abbccdda
reviewed
May 10, 2019
mumrah
reviewed
May 15, 2019
Member
There was a problem hiding this comment.
+1 for replacing the sentinel Partition instance with this
mumrah
reviewed
May 15, 2019
mumrah
left a comment
mumrah
left a comment
Member
There was a problem hiding this comment.
LGTM. Agree we probably want a JIRA since this is rather large (though logically equivalent)
Contributor
Author
|
@abbccdda @mumrah Thanks for reviews. I opened https://issues.apache.org/jira/browse/KAFKA-8371 for this change. I will address comments shortly. |
hachikuji
changed the title
hachikuji
force-pushed
the
simplify-partition-testing
branch
from
May 16, 2019 00:15
ecfaa0f to
1f7a462
Compare
hachikuji
force-pushed
the
simplify-partition-testing
branch
from
May 22, 2019 00:26
1f7a462 to
0fb6599
Compare
Contributor
Author
|
Note that one side benefit of this refactor is that |
hachikuji
force-pushed
the
simplify-partition-testing
branch
from
May 22, 2019 21:10
0fb6599 to
4636510
Compare
3 tasks
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
…e#6705) This patch attempts to simplify the interaction between Partition and the various components from `ReplicaManager`. This is primarily to make unit testing easier. I have also tried to eliminate the OfflinePartition sentinel which has always been unsafe. Reviewers: Boyang Chen <bchen11@outlook.com>, David Arthur <mumrah@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…e#6705) This patch attempts to simplify the interaction between Partition and the various components from `ReplicaManager`. This is primarily to make unit testing easier. I have also tried to eliminate the OfflinePartition sentinel which has always been unsafe. Reviewers: Boyang Chen <bchen11@outlook.com>, David Arthur <mumrah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch attempts to simplify the interaction between Partition and the various components from
ReplicaManager. This is primarily to make unit testing easier. I have also tried to eliminate the OfflinePartition sentinel which has always been unsafe.Committer Checklist (excluded from commit message)