MINOR: Gradle and Gradle plugins versions are extracted into 'gradle/dependencies.gradle' file#6648
Merged
Merged
Conversation
…dependencies.gradle' file
Contributor
Author
|
Prologue: #6436 (review) @ijuma, @ewencp: please review and let me know do you prefer |
ijuma
reviewed
Apr 30, 2019
ijuma
left a comment
ijuma
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Just a couple of minor comments.
Contributor
Author
|
Minor variable name changes (suggested by @ijuma) are applied. |
Contributor
Author
|
retest this please |
Member
|
The PR builder for Java 11 is currently failing due to an Apache Infra problem. There's no behaviour change in this PR so will go ahead and merge to trunk. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…le (apache#6648) Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)