Skip to content

KAFKA-8155: Add 2.2.0 release to system tests#6597

Merged
mjsax merged 3 commits into
apache:trunkfrom
mjsax:kafka-8155-add-220-system-test
Jun 4, 2019
Merged

KAFKA-8155: Add 2.2.0 release to system tests#6597
mjsax merged 3 commits into
apache:trunkfrom
mjsax:kafka-8155-add-220-system-test

Conversation

@mjsax

@mjsax mjsax commented Apr 18, 2019

Copy link
Copy Markdown
Member

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax

mjsax commented Apr 18, 2019

Copy link
Copy Markdown
Member Author

Triggered all system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2515/

Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna

@mjsax

mjsax commented Apr 18, 2019

Copy link
Copy Markdown
Member Author

Should this be cherry-picked to 2.2 branch? Not sure.

bbejeck
bbejeck approved these changes Apr 18, 2019
View reviewed changes

@bbejeck bbejeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsa The tests/docker/Dockerfile will need to be updated as well, I'm sure you know just putting a reminder here.

@bbejeck

bbejeck commented Apr 18, 2019

Copy link
Copy Markdown
Member

Java 8 failed with org.apache.kafka.streams.integration.MetricsIntegrationTest.testStreamMetric
Java 11 failed with kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup

retest this please

@mjsax

mjsax commented Apr 19, 2019

Copy link
Copy Markdown
Member Author

@mjsa The tests/docker/Dockerfile will need to be updated as well, I'm sure you know just putting a reminder here.

Thanks Bill. That would have slipped...

@mjsax

mjsax commented Apr 19, 2019

Copy link
Copy Markdown
Member Author

Retriggered system test that where doomed to fail: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2519/

@mjsax

mjsax commented Apr 23, 2019

Copy link
Copy Markdown
Member Author

Specified wrong branch for system test. Retriggered: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2526/

@mjsax
mjsax force-pushed the kafka-8155-add-220-system-test branch from 8f3db9c to 67922ee Compare May 17, 2019 10:58
@mjsax

mjsax commented May 17, 2019

Copy link
Copy Markdown
Member Author

Rebased to resolve merge conflict. Fixed artifact issue. Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2591/

@mjsax
mjsax force-pushed the kafka-8155-add-220-system-test branch from 67922ee to 9f3be88 Compare May 24, 2019 16:10
@mjsax

mjsax commented May 24, 2019

Copy link
Copy Markdown
Member Author

Rebased this to get latest system test fixes. New system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2631/

abbccdda
abbccdda reviewed May 28, 2019
View reviewed changes

@abbccdda abbccdda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work! Just some minor comments

Comment thread ...upgrade-system-tests-22/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java Outdated

@abbccdda abbccdda May 28, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extra line

Comment thread ...upgrade-system-tests-22/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java Outdated

@abbccdda abbccdda May 28, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 2.2?

@mjsax mjsax May 29, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

cadonna
cadonna reviewed May 28, 2019
View reviewed changes
Comment thread gradle/dependencies.gradle Outdated

@cadonna cadonna May 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be 2.1.1?
I am asking because this list enumerates only the most recent bugfix releases and you removed 2.1.0 in tests/docker/Dockerfile.

@mjsax mjsax May 29, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated in #6596 -- separate PR to allow cherry-picking to older branches.

Comment thread tests/docker/Dockerfile Outdated

@cadonna cadonna May 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be kafka-streams-2.1.1-test.jar?

@mjsax mjsax May 29, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@mjsax

mjsax commented May 29, 2019

Copy link
Copy Markdown
Member Author

Updates this.

Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2655/

@mjsax
mjsax force-pushed the kafka-8155-add-220-system-test branch from 647771d to 9cb5c7c Compare May 31, 2019 20:02
@mjsax

mjsax commented May 31, 2019

Copy link
Copy Markdown
Member Author

Rebased to resolve merge conflict. Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2666/

@mjsax

mjsax commented Jun 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Fix failing system test. Retriggered build: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2679/

@mjsax mjsax mentioned this pull request Jun 3, 2019
Merged
3 tasks
@guozhangwang

guozhangwang commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

LGTM. Please feel free to merge afterwards.

abbccdda
abbccdda approved these changes Jun 3, 2019
View reviewed changes

@abbccdda abbccdda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mjsax

mjsax commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

System test passed. Jenkins passed. Merging this now.

@mjsax
mjsax merged commit ba3dc49 into apache:trunk Jun 4, 2019
mjsax added a commit that referenced this pull request Jun 4, 2019
@mjsax
KAFKA-8155: Add 2.2.0 release to system tests (#6597)
78365dd 
Reviewers: Bill Bejeck <bill@confluent.io>, Boyang Chen <boyang@confluent.io>, Bruno Cadonna <bruno@confluent.io>, Guozhang Wang <guozhang@confuent.io>
@mjsax

mjsax commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

Merged to trunk and cherry-picked to 2.3 branch.

@mjsax
mjsax deleted the kafka-8155-add-220-system-test branch June 4, 2019 04:11
omkreddy added a commit to confluentinc/kafka that referenced this pull request Jun 4, 2019
@omkreddy
Merge remote-tracking branch 'AK_REPO/2.3' into sync-merge-june4
e5caa7b 
* AK_REPO/2.3:
  KAFKA-8155: Add 2.2.0 release to system tests (apache#6597)
  KAFKA-8404: Add HttpHeader to RestClient HTTP Request and Connector REST API (apache#6791)
  KAFKA-8473: Adjust Connect system tests for incremental cooperative rebalancing (apache#6872)
  KAFKA-8475: Temporarily restore SslFactory.sslContext() helper
  KAFKA-8449: Restart tasks on reconfiguration under incremental cooperative rebalancing (apache#6850)
  KAFKA-8426; Fix for keeping the ConfigProvider configs consistent with KIP-297 (apache#6750)
  KAFKA-8425: Fix for correctly handling immutable maps (KIP-421 bug) (apache#6795)
  MINOR: Reordering the props modification with configs construction
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@mjsax @pengxiaolong
KAFKA-8155: Add 2.2.0 release to system tests (apache#6597)
fc8504d 
Reviewers: Bill Bejeck <bill@confluent.io>, Boyang Chen <boyang@confluent.io>, Bruno Cadonna <bruno@confluent.io>, Guozhang Wang <guozhang@confuent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cadonna cadonna cadonna left review comments
@bbejeck bbejeck bbejeck approved these changes
@abbccdda abbccdda abbccdda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mjsax @bbejeck @guozhangwang @cadonna @abbccdda