Skip to content

MINOR: make LogCleaner.shouldRetainRecord more clear to read #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 3 commits into from
Apr 25, 2019
Merged

MINOR: make LogCleaner.shouldRetainRecord more clear to read #6590

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1751f7c
MINOR: make LogCleaner.shouldRetainRecord more clear to read
Apr 17, 2019
68dcd83
rename variable's name `latest` to `latestOffsetForKey`
FreeeeLy Apr 20, 2019
66db679
invert obsoleteDelete expression and change comments to make them con…
Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions core/src/main/scala/kafka/log/LogCleaner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,13 +731,14 @@ private[log] class Cleaner(val id: Int,
if (record.hasKey) {
val key = record.key
val foundOffset = map.get(key)
/* two cases in which we can get rid of a message:
* 1) if there exists a message with the same key but higher offset
* 2) if the message is a delete "tombstone" marker and enough time has passed
/* First,the message must have the latest offset for the key
* then there are two cases in which we can retain a message:
* 1) The message has value
* 2) The message doesn't has value but it can't be deleted now.
*/
val redundant = foundOffset >= 0 && record.offset < foundOffset
val obsoleteDelete = !retainDeletes && !record.hasValue
!redundant && !obsoleteDelete
val latestOffsetForKey = record.offset() >= foundOffset
val isRetainedValue = record.hasValue || retainDeletes
latestOffsetForKey && isRetainedValue
} else {
stats.invalidMessage()
false
Expand Down