Skip to content

KAFKA-7288; Fix check in SelectorTest to wait for no buffered bytes #6415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajinisivaram merged 1 commit into from
Mar 9, 2019
Merged

KAFKA-7288; Fix check in SelectorTest to wait for no buffered bytes #6415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ private KafkaChannel createConnectionWithStagedReceives(int maxStagedReceives) t
do {
selector.poll(1000);
} while (selector.completedReceives().isEmpty());
} while (selector.numStagedReceives(channel) == 0 && !channel.hasBytesBuffered() && --retries > 0);
} while ((selector.numStagedReceives(channel) == 0 || channel.hasBytesBuffered()) && --retries > 0);
assertTrue("No staged receives after 100 attempts", selector.numStagedReceives(channel) > 0);
// We want to return without any bytes buffered to ensure that channel will be closed after idle time
assertFalse("Channel has bytes buffered", channel.hasBytesBuffered());
Expand Down