KAFKA-8053: Provide better error in kafka-topics.sh message when topi…#6381
Closed
scholzj wants to merge 1 commit into
Closed
KAFKA-8053: Provide better error in kafka-topics.sh message when topi…#6381scholzj wants to merge 1 commit into
scholzj wants to merge 1 commit into
Conversation
3 tasks
Contributor
|
Thanks for the patch. This was resolved by #7094. I will go ahead and close. |
scholzj
deleted the
kafka-topics-fix-error-message-when-no-topic-is-found
branch
July 18, 2019 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…c doesn't exist
This PR tries to address KAFKA-8053. It passes the option with which the user originally called the
kafka-topics.shtool to theensureTopicExistsmethod to try to produce better error message. It also handles the case when the user doesn't specify any topics at all (which is for example allowed for--describe).If you prefer to address this differently, let me know and I can update the PR.
Committer Checklist (excluded from commit message)