Skip to content

KAFKA-7766: Fail fast PR builds #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 5 commits into from
Feb 2, 2019
Merged

KAFKA-7766: Fail fast PR builds #6059

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7980f8
Update jenkins.sh to fail fast
mumrah Dec 21, 2018
3e2d483
Introduce a checkstyle error
mumrah Dec 21, 2018
0bf0973
Revert "Introduce a checkstyle error"
mumrah Dec 21, 2018
3ed9563
Move rat to validation checks
mumrah Dec 21, 2018
f089249
Add profile flag for more insight into build time
mumrah Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion jenkins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,14 @@
# This script is used for verifying changes in Jenkins. In order to provide faster feedback, the tasks are ordered so
# that faster tasks are executed in every module before slower tasks (if possible). For example, the unit tests for all
# the modules are executed before the integration tests.
./gradlew clean compileJava compileScala compileTestJava compileTestScala spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain unitTest rat integrationTest --no-daemon --continue -PxmlSpotBugsReport=true -PtestLoggingEvents=started,passed,skipped,failed "$@"

# Run validation checks (compilation and static analysis)
./gradlew clean compileJava compileScala compileTestJava compileTestScala \
spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain rat \
--profile --no-daemon --continue -PxmlSpotBugsReport=true "$@" \
|| { echo 'Validation steps failed'; exit 1; }

# Run tests
./gradlew unitTest integrationTest \
--profile --no-daemon --continue -PtestLoggingEvents=started,passed,skipped,failed "$@" \

@ijuma ijuma Jan 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the --profile information is printed to a file. How would one see that for a Jenkins build?

@ijuma ijuma Jan 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumrah Can you elaborate on this one? Apart from that, I think we are good to merge.

@mumrah mumrah Jan 22, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure: the --profile flag tells gradle to time all of the tasks in during a build. It breaks it down so you can see how much time is spent during the different task phases. It's quite useful when investigating slow builds. The HTML reports generated by the profiling could be archived by Jenkins and/or published using the HTML publisher plugin (similar to a coverage report or junit results)

@ijuma ijuma Feb 2, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please file a JIRA with details about what we should do in Jenkins to make this useful?

|| { echo 'Test steps failed'; exit 1; }