Skip to content

MINOR: Gracefully close the consumer in ConsumeBenchWorker #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stanislavkozlovski wants to merge 5 commits into from
Closed

MINOR: Gracefully close the consumer in ConsumeBenchWorker #6033

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1674551
Gracefully close the ConsumeBenchWorker
stanislavkozlovski Dec 14, 2018
78a50d4
Bring doneFuture.complete() back down
stanislavkozlovski Dec 14, 2018
ddb6de8
Close consumer before calling done
stanislavkozlovski Dec 14, 2018
97d3a4c
Rename abort -> abortAndThrow
stanislavkozlovski Dec 14, 2018
020818d
Remove extra whitespace in last commit
stanislavkozlovski Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/src/main/java/org/apache/kafka/trogdor/workload/ConsumeBenchWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,9 @@ public Void call() throws Exception {
long curTimeMs = Time.SYSTEM.milliseconds();
log.info("{} Consumed total number of messages={}, bytes={} in {} ms. status: {}",
clientId, messagesConsumed, bytesConsumed, curTimeMs - startTimeMs, statusData);
consumer.close();

@ijuma ijuma Dec 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we'd want to close the consumer before completing doneFuture right? Given that, it seems like we should do it before calling abort and right after the finally. What do you think?

@ijuma ijuma Dec 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I suggest renaming abort to abortAndThrow.

@stanislavkozlovski stanislavkozlovski Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we're not done until we close the consumer

}
doneFuture.complete("");
consumer.close();
return null;
}
}
Expand Down