Skip to content

Increase acceptable duration time for ReassignPartitionsClusterTest#shouldExecuteThrottledReassignment #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 5 commits into from
Feb 2, 2019
+6 −2
Merged

Increase acceptable duration time for ReassignPartitionsClusterTest#shouldExecuteThrottledReassignment #5887

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dfad52
Increase timeout for ReassignPartitionsClusterTest#shouldExecuteThrot…
stanislavkozlovski Nov 6, 2018
6e949f4
Lower replica.backoff.ms
stanislavkozlovski Nov 21, 2018
acfac2a
Attach fetch backoff config in ReassignPartitionsClusterTest
stanislavkozlovski Nov 27, 2018
e00ab27
Add comment explaining config change
stanislavkozlovski Jan 2, 2019
5c6a03c
Make style consistent
stanislavkozlovski Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/test/scala/unit/kafka/admin/ReassignPartitionsClusterTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ class ReassignPartitionsClusterTest extends ZooKeeperTestHarness with Logging {
//Then command should have taken longer than the throttle rate
assertTrue(s"Expected replication to be > ${expectedDurationSecs * 0.9 * 1000} but was $took",
took > expectedDurationSecs * 0.9 * 1000)
assertTrue(s"Expected replication to be < ${expectedDurationSecs * 2 * 1000} but was $took",
assertTrue(s"Expected replication to be < ${expectedDurationSecs * 3 * 1000} but was $took",
took < expectedDurationSecs * 2 * 1000)

@rajinisivaram rajinisivaram Nov 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the changing the error message, not the actual check :-) In any case, I am not sure this test makes any sense any more if we can't even get it to work with double the expected value. We should see if we can change message size or number of messages to get it to work consistently with a duration that is between 0.9t and 2t.

@stanislavkozlovski stanislavkozlovski Nov 20, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops, hehe :)
I will try to tweak it a bit but it is worth mentioning that these slow runs are definitely outliers. Less than 1 in 50 locally

}

Expand Down