Skip to content

MINOR: Bump timeout for sending records #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 3 commits into from
Oct 28, 2018
Merged

MINOR: Bump timeout for sending records #5843

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67bda04
MINOR: Bump timeouts to be consistent with change to 2.0
bbejeck Oct 25, 2018
618675b
MINOR: Increase low timeouts to help with test flakiness, update erro…
bbejeck Oct 25, 2018
e2cea79
MINOR: Increase timeout to 30 seconds
bbejeck Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public void shouldFinishGlobalStoreOperationOnShutDown() throws Exception {
public boolean conditionMet() {
return firstRecordProcessed;
}
}, 10000L, "Has not processed record within 10 seconds");
}, "Has not processed record within 15 seconds");

@mjsax mjsax Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on the other PR. Should we increase to 30 seconds?

@bbejeck bbejeck Oct 26, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree I'll update all related PRs to use a 30 second timeout


kafkaStreams.close(Duration.ofSeconds(30));

Expand Down
4 changes: 2 additions & 2 deletions streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public void shouldCompactTopicsForKeyValueStoreChangelogs() throws Exception {
//
// Step 3: Verify the state changelog topics are compact
//
waitForCompletion(streams, 2, 10000);
waitForCompletion(streams, 2, 15000);
streams.close();

final Properties changelogProps = getTopicProperties(ProcessorStateManager.storeChangelogTopic(appID, "Counts"));
Expand Down Expand Up @@ -203,7 +203,7 @@ public void shouldCompactAndDeleteTopicsForWindowStoreChangelogs() throws Except
//
// Step 3: Verify the state changelog topics are compact
//
waitForCompletion(streams, 2, 5000);
waitForCompletion(streams, 2, 15000);
streams.close();
final Properties properties = getTopicProperties(ProcessorStateManager.storeChangelogTopic(appID, "CountWindows"));
final List<String> policies = Arrays.asList(properties.getProperty(LogConfig.CleanupPolicyProp()).split(","));
Expand Down