Skip to content

MINOR: Increase low timeouts to help with test flakiness #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 3 commits into from
Oct 26, 2018
Merged

MINOR: Increase low timeouts to help with test flakiness #5841

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de06eb1
MINOR: Increase low timeouts to help with test flakiness
bbejeck Oct 25, 2018
471633c
MINOR: correct error message
bbejeck Oct 25, 2018
faa642e
MINOR: Increase timeout to 30 seconds
bbejeck Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public void shouldFinishGlobalStoreOperationOnShutDown() throws Exception {
public boolean conditionMet() {
return firstRecordProcessed;
}
}, 5000L, "Has not processed record within 5 seconds");
}, "Has not processed record within 5 seconds");

@bbejeck bbejeck Oct 25, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When no timeout is specified the default time of 15 seconds is used.


kafkaStreams.close(30, TimeUnit.SECONDS);

Expand Down
4 changes: 2 additions & 2 deletions streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public Iterable<String> apply(final String value) {
//
// Step 3: Verify the state changelog topics are compact
//
waitForCompletion(streams, 2, 5000);
waitForCompletion(streams, 2, 15000);
streams.close();

final Properties changelogProps = getTopicProperties(ProcessorStateManager.storeChangelogTopic(appID, "Counts"));
Expand Down Expand Up @@ -206,7 +206,7 @@ public Iterable<String> apply(final String value) {
//
// Step 3: Verify the state changelog topics are compact
//
waitForCompletion(streams, 2, 5000);
waitForCompletion(streams, 2, 15000);
streams.close();
final Properties properties = getTopicProperties(ProcessorStateManager.storeChangelogTopic(appID, "CountWindows"));
final List<String> policies = Arrays.asList(properties.getProperty(LogConfig.CleanupPolicyProp()).split(","));
Expand Down