KAFKA-7535:KafkaConsumer doesn't report records-lag if isolation.level is read_committed - #5835
KAFKA-7535:KafkaConsumer doesn't report records-lag if isolation.level is read_committed#5835lambdaliu wants to merge 3 commits into
Conversation
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can you please add a test? cc @dhruvilshah3
|
If you don't have time to write a test, let us know and we will help. |
|
@lambdaliu Thanks for the fix! Currently the patch still uses |
|
@ijuma @lindong28 Thanks for your review. I added some tests to changed FetchResponse.INVALID_LAST_STABLE_OFFSET to lastStableOffset under date conversion, please review this PR again. |
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
@lambdaliu Thanks for the update. LGTM.
|
@dhruvilshah3 Would you like to review this PR? |
…el is read_committed FetchResponse should return the partitionData's lastStabeleOffset Author: lambdaliu <lambdaliu@tencent.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Dhruvil Shah <dhruvil@confluent.io>, Dong Lin <lindong28@gmail.com> Closes #5835 from lambdaliu/KAFKA-7535 (cherry picked from commit 73da591) Signed-off-by: Dong Lin <lindong28@gmail.com>
|
@lindong28 can we cherry-pick this to 2.0 as well? That's when the regression was introduced. |
…el is read_committed FetchResponse should return the partitionData's lastStabeleOffset Author: lambdaliu <lambdaliu@tencent.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Dhruvil Shah <dhruvil@confluent.io>, Dong Lin <lindong28@gmail.com> Closes #5835 from lambdaliu/KAFKA-7535
|
Thanks for the patch. Merged to 2.0, 2.1 and trunk. @ijuma The PR could not merge cleanly into 2.0. I was manually modifying the patch :) |
|
Perfect, thanks @lindong28 and @lambdaliu. |
…el is read_committed FetchResponse should return the partitionData's lastStabeleOffset Author: lambdaliu <lambdaliu@tencent.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Dhruvil Shah <dhruvil@confluent.io>, Dong Lin <lindong28@gmail.com> Closes apache#5835 from lambdaliu/KAFKA-7535
4 participants
FetchResponse should return the partitionData's lastStabeleOffset
Committer Checklist (excluded from commit message)