MINOR: Reduce ResetConsumerGroupOffsetTest flakiness#5830
Closed
stanislavkozlovski wants to merge 1 commit into
Closed
MINOR: Reduce ResetConsumerGroupOffsetTest flakiness#5830stanislavkozlovski wants to merge 1 commit into
stanislavkozlovski wants to merge 1 commit into
Conversation
ijuma
reviewed
Oct 23, 2018
ijuma
left a comment
ijuma
left a comment
Member
There was a problem hiding this comment.
Hmm, this seems to indicate a real problem or a misconfigured timeout. The command itself should be resilient to the coordinator being temporarily unavailable, right?
Contributor
|
sometime back, I raised PR #5578 to add retry-logic to Adminclient: |
Contributor
Author
|
@ijuma I don't think a timeout would help in this case - the request is returning an error. I'm not exactly sure what's causing this but I believe it might be some race condition. I didn't manage to reproduce this locally |
Member
|
@stanislavkozlovski See @omkreddy's PR. |
Member
|
Closing this as I believe this has been fixed by retrying at the AdminClient level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in
kafka.admin.ResetConsumerGroupOffsetTestsometimes fail withI think that it would be useful to have some retry mechanism in place to hop over transient errors