Skip to content

MINOR: remove duplicated code in ConsumerPerformance #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 3 commits into from
Oct 28, 2018
Merged

MINOR: remove duplicated code in ConsumerPerformance #5828

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
331865a
MINOR: remove duplicated code when subscribing topics for consumer in…
huxi-2b Oct 23, 2018
5c5c236
Merge branch 'trunk' of https://github.com/apache/kafka into remove_u…
huxi-2b Oct 24, 2018
51beb42
removed useless variables
huxi-2b Oct 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions core/src/main/scala/kafka/tools/ConsumerPerformance.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import org.apache.kafka.common.serialization.ByteArrayDeserializer
import org.apache.kafka.common.utils.Utils
import org.apache.kafka.common.{Metric, MetricName, TopicPartition}
import kafka.utils.{CommandLineUtils, ToolsUtils}
import java.util.{Collections, Properties, Random}
import java.util.{Properties, Random}
import java.text.SimpleDateFormat
import java.time.Duration

Expand All @@ -54,7 +54,6 @@ object ConsumerPerformance extends LazyLogging {

var startMs, endMs = 0L
val consumer = new KafkaConsumer[Array[Byte], Array[Byte]](config.props)
consumer.subscribe(Collections.singletonList(config.topic))
startMs = System.currentTimeMillis
consume(consumer, List(config.topic), config.numMessages, config.recordFetchTimeoutMs, config, totalMessagesRead, totalBytesRead, joinGroupTimeInMs, startMs)
endMs = System.currentTimeMillis
Expand Down Expand Up @@ -121,10 +120,9 @@ object ConsumerPerformance extends LazyLogging {
}})

// Now start the benchmark
val startMs = System.currentTimeMillis
var lastReportTime: Long = startMs
var lastConsumedTime = System.currentTimeMillis
var currentTimeMillis = lastConsumedTime
var currentTimeMillis = System.currentTimeMillis
var lastReportTime: Long = currentTimeMillis
var lastConsumedTime = currentTimeMillis

while (messagesRead < count && currentTimeMillis - lastConsumedTime <= timeout) {
val records = consumer.poll(Duration.ofMillis(100)).asScala
Expand Down