Skip to content

KAFKA-7403: Follow-up fix for KAFKA-4682 (KIP-211) to correct some edge cases#5690

Merged
hachikuji merged 1 commit into
apache:trunkfrom
vahidhashemian:KAFKA-7403
Sep 25, 2018
Merged

KAFKA-7403: Follow-up fix for KAFKA-4682 (KIP-211) to correct some edge cases#5690
hachikuji merged 1 commit into
apache:trunkfrom
vahidhashemian:KAFKA-7403

Conversation

@vahidhashemian

Copy link
Copy Markdown
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…ge cases

Co-authored-by: Jason Gustafson <jason@confluent.io>

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Note that I have a test case which hits this in #5689, so we can skip it here.

@hachikuji
hachikuji merged commit 2933f21 into apache:trunk Sep 25, 2018
@vahidhashemian

Copy link
Copy Markdown
Contributor Author

Thanks a lot!

jonlee2 pushed a commit to linkedin/kafka that referenced this pull request Jan 8, 2019
…t commit value (apache#5690)

This fixes a regression caused by KAFKA-4682 (KIP-211) which caused offset commit failures after upgrading from an older version which used the v1 inter-broker format.
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
…t commit value (apache#5690)

This fixes a regression caused by KAFKA-4682 (KIP-211) which caused offset commit failures after upgrading from an older version which used the v1 inter-broker format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants