MINOR: rename InternalProcessorContext.initialized - #5672
Merged
Conversation
Contributor
Author
3 tasks
Contributor
Author
|
Hmm. The java 10 build failed for Retest this, please. |
bbejeck
approved these changes
Sep 21, 2018
bbejeck
left a comment
bbejeck
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this PR. LGTM
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We named this method
initializedbecause it marks the context as having been initialized.The downside is that it sounds more like a getter upon casual reading, which is weird since it's
void.Note also that the inverse method is already called
uninitialize.Committer Checklist (excluded from commit message)