MINOR: don't log config during unit tests#5671
Conversation
There was a problem hiding this comment.
Could we do final StreamsConfig streamsConfig = new StreamsConfig(config, false); instead? I tried locally and it worked.
There was a problem hiding this comment.
That works for TopologyTestDriver, but not MockProcessorContext because that constructor is protected, and the TopologyTestDriver happens to be in the same package as StreamsConfig.
I previously had the QuietStreamsConfig used only in MockProcessorContext, but the feedback was to also use it in TopologyTestDriver.
Seeing it this way, do you think it makes sense just to use the protected constructor in TopologyTestDriver, and the QuietStreamsConfig in the MockProcessorContext?
There was a problem hiding this comment.
With the additional context, I'm fine with the PR as is.
|
Trunk should be fixed now. Retest this, please. |
|
failure unrelated restest this please |
|
Thanks, @bbejeck ! |
There was a problem hiding this comment.
Why do we need an additional package? org.apache.kafka.streams.internals seems sufficient.
|
@mjsax I've moved the class as you suggested and also rebased on current trunk. |
Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
The StreamsConfig class by default prints its configuration values during construction.
This is valuable at runtime as a record of the actual configuration, but during unit testing,
it results in excessive output.
Committer Checklist (excluded from commit message)