Skip to content

MINOR: Remove ignored tests that hang, added new versions for EOS tests - #5666

Merged
guozhangwang merged 1 commit into
apache:trunkfrom
bbejeck:MINOR-remove_ignored_tests
Sep 19, 2018
Merged

MINOR: Remove ignored tests that hang, added new versions for EOS tests#5666
guozhangwang merged 1 commit into
apache:trunkfrom
bbejeck:MINOR-remove_ignored_tests

Conversation

@bbejeck

@bbejeck bbejeck commented Sep 19, 2018

Copy link
Copy Markdown
Member

The streams_broker_compatibility_test::test_timeout_on_pre_010_brokers test is ignored. The test uses broker version 0.9 latest and 0.8 latest. At one point Streams would throw a BrokerNotFoundException, but that exception is no longer thrown so this will hang forever, thus should just be removed.

Also added new versions to test_compatible_brokers_eos_disabled for consistency.

For testing ran branch builder https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1964/

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck

bbejeck commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

@guozhangwang, @mjsax, and @vvcephei for review

@vvcephei vvcephei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guozhangwang guozhangwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guozhangwang
guozhangwang merged commit df00f1a into apache:trunk Sep 19, 2018
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
…ts (apache#5666)

Reviewers: John Roesler <vvcephei@users.noreply.github.com>, Guozhang Wang <wangguoz@gmail.com>
@bbejeck
bbejeck deleted the MINOR-remove_ignored_tests branch July 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants