Skip to content

KAFKA-2423: Introduce Scalastyle#560

Closed
granthenke wants to merge 1 commit into
apache:trunkfrom
granthenke:scalastyle
Closed

KAFKA-2423: Introduce Scalastyle#560
granthenke wants to merge 1 commit into
apache:trunkfrom
granthenke:scalastyle

Conversation

@granthenke

Copy link
Copy Markdown
Member

Just the buildscript changes and rules configuration.

@granthenke

Copy link
Copy Markdown
Member Author

Getting the discussion stared on ScalaStyle. This pull request only contains the integration to gradle and the configuration of the proposed scalastyle rules. Once this is reviewed and the rules are agreed upon and I can add a commit with the changes to make the build pass and reduce the noise from some of the ones we want to enable but can't yet.

@granthenke

Copy link
Copy Markdown
Member Author

@ijuma Any feedback on the proposed rules?

Just the buildscript changes and rules configuration.
@ijuma

ijuma commented Nov 30, 2015

Copy link
Copy Markdown
Member

@granthenke I haven't had a chance to look at them in detail and it probably won't happen before next week.

@granthenke

Copy link
Copy Markdown
Member Author

@ijuma Thanks for the update!

@guozhangwang

Copy link
Copy Markdown
Contributor

@granthenke How is this PR related to #284? BTW would you like to continue work on either one of these two?

@asfbot

asfbot commented Dec 21, 2016

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/339/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot

asfbot commented Dec 21, 2016

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/338/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot

asfbot commented Dec 21, 2016

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/340/
Test FAILed (JDK 8 and Scala 2.11).

efeg added a commit to efeg/kafka that referenced this pull request Jan 29, 2020
@vvcephei

vvcephei commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Hi @granthenke ,

It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new one)!

Thanks,
John

@vvcephei vvcephei closed this Feb 9, 2022
juha-aiven pushed a commit to aiven/kafka that referenced this pull request Apr 2, 2026
…pache#560)

Add startup validation that enforces the dependency chain between
diskless feature flags:

  diskless.storage.system.enable
    → diskless.managed.rf.enable
      → diskless.allow.from.classic.enable (+ remote.log.storage.system.enable)

Brokers now fail fast with a clear error message if flags are enabled
without their prerequisites.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants