-
Notifications
You must be signed in to change notification settings - Fork 15.4k
KAFKA-7223: Suppress API with only immediate emit #5567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
160 changes: 160 additions & 0 deletions
160
streams/src/main/java/org/apache/kafka/streams/kstream/Suppressed.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.streams.kstream; | ||
|
|
||
| import org.apache.kafka.streams.kstream.internals.suppress.EagerBufferConfigImpl; | ||
| import org.apache.kafka.streams.kstream.internals.suppress.FinalResultsSuppressionBuilder; | ||
| import org.apache.kafka.streams.kstream.internals.suppress.StrictBufferConfigImpl; | ||
| import org.apache.kafka.streams.kstream.internals.suppress.SuppressedImpl; | ||
|
|
||
| import java.time.Duration; | ||
|
|
||
| public interface Suppressed<K> { | ||
|
|
||
| /** | ||
| * Marker interface for a buffer configuration that is "strict" in the sense that it will strictly | ||
| * enforce the time bound and never emit early. | ||
| */ | ||
| interface StrictBufferConfig extends BufferConfig<StrictBufferConfig> { | ||
|
|
||
| } | ||
|
|
||
| interface BufferConfig<BC extends BufferConfig<BC>> { | ||
| /** | ||
| * Create a size-constrained buffer in terms of the maximum number of keys it will store. | ||
| */ | ||
| static BufferConfig<?> maxRecords(final long recordLimit) { | ||
| return new EagerBufferConfigImpl(recordLimit, Long.MAX_VALUE); | ||
| } | ||
|
|
||
| /** | ||
| * Set a size constraint on the buffer in terms of the maximum number of keys it will store. | ||
| */ | ||
| BC withMaxRecords(final long recordLimit); | ||
|
|
||
| /** | ||
| * Create a size-constrained buffer in terms of the maximum number of bytes it will use. | ||
| */ | ||
| static BufferConfig<?> maxBytes(final long byteLimit) { | ||
| return new EagerBufferConfigImpl(Long.MAX_VALUE, byteLimit); | ||
| } | ||
|
|
||
| /** | ||
| * Set a size constraint on the buffer, the maximum number of bytes it will use. | ||
| */ | ||
| BC withMaxBytes(final long byteLimit); | ||
|
|
||
| /** | ||
| * Create a buffer unconstrained by size (either keys or bytes). | ||
| * | ||
| * As a result, the buffer will consume as much memory as it needs, dictated by the time bound. | ||
| * | ||
| * If there isn't enough heap available to meet the demand, the application will encounter an | ||
| * {@link OutOfMemoryError} and shut down (not guaranteed to be a graceful exit). Also, note that | ||
| * JVM processes under extreme memory pressure may exhibit poor GC behavior. | ||
| * | ||
| * This is a convenient option if you doubt that your buffer will be that large, but also don't | ||
| * wish to pick particular constraints, such as in testing. | ||
| * | ||
| * This buffer is "strict" in the sense that it will enforce the time bound or crash. | ||
| * It will never emit early. | ||
| */ | ||
| static StrictBufferConfig unbounded() { | ||
| return new StrictBufferConfigImpl(); | ||
| } | ||
|
|
||
| /** | ||
| * Set the buffer to be unconstrained by size (either keys or bytes). | ||
| * | ||
| * As a result, the buffer will consume as much memory as it needs, dictated by the time bound. | ||
| * | ||
| * If there isn't enough heap available to meet the demand, the application will encounter an | ||
| * {@link OutOfMemoryError} and shut down (not guaranteed to be a graceful exit). Also, note that | ||
| * JVM processes under extreme memory pressure may exhibit poor GC behavior. | ||
| * | ||
| * This is a convenient option if you doubt that your buffer will be that large, but also don't | ||
| * wish to pick particular constraints, such as in testing. | ||
| * | ||
| * This buffer is "strict" in the sense that it will enforce the time bound or crash. | ||
| * It will never emit early. | ||
| */ | ||
| StrictBufferConfig withNoBound(); | ||
|
|
||
| /** | ||
| * Set the buffer to gracefully shut down the application when any of its constraints are violated | ||
| * | ||
| * This buffer is "strict" in the sense that it will enforce the time bound or shut down. | ||
| * It will never emit early. | ||
| */ | ||
| StrictBufferConfig shutDownWhenFull(); | ||
|
|
||
| /** | ||
| * Sets the buffer to use on-disk storage if it requires more memory than the constraints allow. | ||
| * | ||
| * This buffer is "strict" in the sense that it will never emit early. | ||
| */ | ||
| StrictBufferConfig spillToDiskWhenFull(); | ||
|
|
||
| /** | ||
| * Set the buffer to just emit the oldest records when any of its constraints are violated. | ||
| * | ||
| * This buffer is "not strict" in the sense that it may emit early, so it is suitable for reducing | ||
| * duplicate results downstream, but does not promise to eliminate them. | ||
| */ | ||
| BufferConfig emitEarlyWhenFull(); | ||
| } | ||
|
|
||
| /** | ||
| * Configure the suppression to emit only the "final results" from the window. | ||
| * | ||
| * By default all Streams operators emit results whenever new results are available. | ||
| * This includes windowed operations. | ||
| * | ||
| * This configuration will instead emit just one result per key for each window, guaranteeing | ||
| * to deliver only the final result. This option is suitable for use cases in which the business logic | ||
| * requires a hard guarantee that only the final result is propagated. For example, sending alerts. | ||
| * | ||
| * To accomplish this, the operator will buffer events from the window until the window close (that is, | ||
| * until the end-time passes, and additionally until the grace period expires). Since windowed operators | ||
|
vvcephei marked this conversation as resolved.
Outdated
|
||
| * are required to reject late events for a window whose grace period is expired, there is an additional | ||
| * guarantee that the final results emitted from this suppression will match any queriable state upstream. | ||
| * | ||
| * @param bufferConfig A configuration specifying how much space to use for buffering intermediate results. | ||
| * This is required to be a "strict" config, since it would violate the "final results" | ||
| * property to emit early and then issue an update later. | ||
| * @param <K> The key type for the KTable to apply this suppression to. "Final results" mode is only available | ||
| * on Windowed KTables (this is enforced by the type parameter). | ||
| * @return a "final results" mode suppression configuration | ||
| */ | ||
| static <K extends Windowed> Suppressed<K> untilWindowCloses(final StrictBufferConfig bufferConfig) { | ||
| return new FinalResultsSuppressionBuilder<>(bufferConfig); | ||
| } | ||
|
|
||
| /** | ||
| * Configure the suppression to wait {@code timeToWaitForMoreEvents} amount of time after receiving a record | ||
| * before emitting it further downstream. If another record for the same key arrives in the mean time, it replaces | ||
| * the first record in the buffer but does <em>not</em> re-start the timer. | ||
| * | ||
| * @param timeToWaitForMoreEvents The amount of time to wait, per record, for new events. | ||
| * @param bufferConfig A configuration specifying how much space to use for buffering intermediate results. | ||
| * @param <K> The key type for the KTable to apply this suppression to. | ||
| * @return a suppression configuration | ||
| */ | ||
| static <K> Suppressed<K> untilTimeLimit(final Duration timeToWaitForMoreEvents, final BufferConfig bufferConfig) { | ||
| return new SuppressedImpl<>(timeToWaitForMoreEvents, bufferConfig, null); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KIP has different generic types.