Skip to content

MINOR: Producers should set delivery timeout instead of retries #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 8 commits into from
Aug 1, 2018
Merged

MINOR: Producers should set delivery timeout instead of retries #5425

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
254c077
MINOR: MirrorMaker should set producer delivery timeout
hachikuji Jul 26, 2018
f7494dd
A few additional updates
hachikuji Jul 26, 2018
81ebf29
Prefer use of delivery timeout over retries
hachikuji Jul 27, 2018
7ed56b2
A few more cleanups and review comments
hachikuji Jul 27, 2018
5a1f744
Fix checkstyle error in EosTestClient
hachikuji Jul 27, 2018
e02c5ec
Address review comments
hachikuji Jul 27, 2018
2d3670b
Use retries=0 in test case to ensure expected error is raised
hachikuji Jul 30, 2018
eae84c1
Fix failing tests
hachikuji Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/tools/MirrorMaker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ object MirrorMaker extends Logging with KafkaMetricsGroup {
val sync = producerProps.getProperty("producer.type", "async").equals("sync")
producerProps.remove("producer.type")
// Defaults to no data loss settings.
maybeSetDefaultProperty(producerProps, ProducerConfig.RETRIES_CONFIG, Int.MaxValue.toString)
maybeSetDefaultProperty(producerProps, ProducerConfig.DELIVERY_TIMEOUT_MS_CONFIG, Int.MaxValue.toString)
maybeSetDefaultProperty(producerProps, ProducerConfig.MAX_BLOCK_MS_CONFIG, Long.MaxValue.toString)
maybeSetDefaultProperty(producerProps, ProducerConfig.ACKS_CONFIG, "all")
maybeSetDefaultProperty(producerProps, ProducerConfig.MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION, "1")
Expand Down