Skip to content

HOTFIX: Fix checkstyle errors in MetricsTest #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 1 commit into from
Jul 6, 2018
Merged

HOTFIX: Fix checkstyle errors in MetricsTest #5345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 23 additions & 27 deletions clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,16 +624,15 @@ public void testConcurrentReadUpdate() throws Exception {
final AtomicBoolean alive = new AtomicBoolean(true);
executorService = Executors.newSingleThreadExecutor();
executorService.submit(new ConcurrentMetricOperation(alive, "record", new Runnable() {
@Override
public void run() {
while (alive.get()) {
for (Sensor sensor : sensors) {
sensor.record(random.nextInt(10000));
}
}
@Override
public void run() {
while (alive.get()) {
for (Sensor sensor : sensors) {
sensor.record(random.nextInt(10000));
}
})
);
}
}
}));

for (int i = 0; i < 10000; i++) {
if (sensors.size() > 5) {
Expand Down Expand Up @@ -708,28 +707,25 @@ public void run() {
}
}
}
})
);
}));
Future<?> readFuture = executorService.submit(new ConcurrentMetricOperation(alive, "read", new Runnable() {
@Override
public void run() {
while (alive.get()) {
for (Sensor sensor : sensors) {
for (Metric metric : sensor.metrics()) {
assertNotNull("Invalid metric value", metric.metricValue());
}
}
@Override
public void run() {
while (alive.get()) {
for (Sensor sensor : sensors) {
for (Metric metric : sensor.metrics()) {
assertNotNull("Invalid metric value", metric.metricValue());
}
}
})
);
}
}
}));
Future<?> reportFuture = executorService.submit(new ConcurrentMetricOperation(alive, "report", new Runnable() {
@Override
public void run() {
reporter.processMetrics();
}
})
);
@Override
public void run() {
reporter.processMetrics();
}
}));

for (int i = 0; i < 10000; i++) {
if (sensors.size() > 10) {
Expand Down