MINOR: Use FetchRequest v8 and ListOffsetRequest v3 in ReplicaFetcherThread#5342
Merged
Merged
Conversation
If inter.broker.protocol.version is 2.0-IV1 or newer.
ijuma
changed the title
ijuma
force-pushed
the
use-fetch-v8-in-replica-fetcher
branch
from
July 6, 2018 14:41
7983e67 to
49cfa6c
Compare
| object UnboundedQuota extends ReplicaQuota { | ||
| override def isThrottled(topicPartition: TopicPartition): Boolean = false | ||
| override def isQuotaExceeded(): Boolean = false | ||
| override def isQuotaExceeded: Boolean = false |
Contributor
There was a problem hiding this comment.
Looks like the build failed because the usages of isQuotaExceeded() weren't updated?
Member
Author
There was a problem hiding this comment.
Oops, not sure how that happened. Will fix.
rajinisivaram
approved these changes
Jul 6, 2018
rajinisivaram
left a comment
rajinisivaram
left a comment
Contributor
There was a problem hiding this comment.
@ijuma Thanks for the PR, LGTM
Member
Author
|
Merging to trunk and 2.0. |
ijuma
added a commit
that referenced
this pull request
Jul 6, 2018
…Thread (#5342) If inter.broker.protocol.version is 2.0-IV1 or newer. Also fixed ListOffsetRequest so that v2 is used, if applicable. Added a unit test which verifies that we use the latest version of the various requests by default. Included a few minor tweaks to make testing easier. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If inter.broker.protocol.version is 2.0-IV1 or newer. Also fixed ListOffsetRequest
so that v2 is used, if applicable.
Added a unit test that verifies that we use the latest version of the various
requests by default. Included a few minor tweaks to make testing easier.
Committer Checklist (excluded from commit message)