MINOR: Remove usages of scala.collection.JavaConversions, and some typo fixes

[vahidhashemian]

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[ijuma]

Thanks for the PR. One comment. Also worth mentioning the typos in the title since that ends up being most of the PR.

[ijuma]

Doesn't seem like calling toMap on every entry is a good idea.

[vahidhashemian]

Is it on every entry? or once the whole props object?
In any case, I refactored it to look more like Scala.

[ijuma]

My bad, I misread the code.

[vahidhashemian]

@ijuma thanks for the feedback. Updated the title in the new commit.
Not sure if I got your point on the inline comment. Made an update anyway, please take a look. Thanks.

[vahidhashemian]

Is it on every entry? or once the whole props object?
In any case, I refactored it to look more like Scala.

[ijuma]

I pushed a couple of trivial changes. LGTM after that. @vahidhashemian, do they look OK to you too?

[ijuma]

Actually, it seems like we still use JavaConversions in InternalTopicIntegrationTest, KafkaEmbedded and EmbeddedKafkaCluster. Any reason why we can't replace those @vahidhashemian?

[vahidhashemian]

@ijuma, your updates look good. I had missed those other ones in the Java code. Removed them in the new commit.

[ijuma]

Retest this please

[vahidhashemian]

I think the failure was related to this hotfix. I did a rebase.

[vahidhashemian]

Retest this please

[vahidhashemian]

Sorry, forgot to pull your earlier commit :(

[ijuma]

LGTM