Skip to content

Minor: Empty list returned by poll() destroys the source task when assert is enabled #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chia7712 wants to merge 1 commit into from
+4 −4
Closed

Minor: Empty list returned by poll() destroys the source task when assert is enabled #4958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void initialize(SourceTaskContext context) {
/**
* <p>
* Poll this source task for new records. If no data is currently available, this method
* should block but return control to the caller regularly (by returning {@code null}) in
* should block but return control to the caller regularly (by returning {@code null} or empty list) in
* order for the task to transition to the {@code PAUSED} state if requested to do so.
* </p>
* <p>
Expand Down
6 changes: 3 additions & 3 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,15 +231,15 @@ public void execute() {

maybeThrowProducerSendException();

if (toSend == null) {
if (toSend == null || toSend.isEmpty()) {
log.trace("{} Nothing to send to Kafka. Polling source for additional records", this);
long start = time.milliseconds();
toSend = poll();
if (toSend != null) {
if (toSend != null && !toSend.isEmpty()) {
recordPollReturned(toSend.size(), time.milliseconds() - start);
}
}
if (toSend == null)
if (toSend == null || toSend.isEmpty())
continue;
log.trace("{} About to send {} records to Kafka", this, toSend.size());
if (!sendRecords())
Expand Down