KAFKA-6760: Responses not logged properly in controller#4834
Merged
Conversation
Added toString() to LeaderAndIsrResponse and StopReplicaResponse
Member
|
Thanks for the PR. Are there any other classes with the same issue? Also, should we add tests? |
Member
Author
Should we just add
Sure I'll add a test for each |
Member
|
@mimaison It's a good question. The alternative is that callers should use |
Member
Author
|
Yeah we don't always have the version information so it's a bit tricky. I've added tests for both Responses. I looked through the controller classes and couldn't find another place where we're printing a Response object. |
Member
Author
|
@ijuma Can you have another look? |
Member
Author
|
Any chance to get this merged? |
Member
|
retest this please |
ijuma
pushed a commit
that referenced
this pull request
Jun 1, 2018
- Override toString in LeaderAndIsrResponse and StopReplicaResponse - Add unit tests Reviewers: Ismael Juma <ismael@juma.me.uk>
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
- Override toString in LeaderAndIsrResponse and StopReplicaResponse - Add unit tests Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added toString() to LeaderAndIsrResponse and StopReplicaResponse
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)