MINOR: Update max.connections.per.ip.overrides config docs#4819
Conversation
|
@hachikuji Pls have a look at this minor doc change. |
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks for following up on this. Left a couple minor suggestions.
There was a problem hiding this comment.
While we're at it, do you think it's worth mentioning that this can be set to 0 if there are overrides? And now that I'm thinking about it, maybe we missed this validation in the other patch?
There was a problem hiding this comment.
@hachikuji Thanks for the review. Updated the doc and added a validation check.
Pls have a look.
There was a problem hiding this comment.
nit: "comma-separated"
Also, maybe
An example value is "hostName:100,127.0.0.1:200."
fa93508 to
38b1573
Compare
38b1573 to
7877b12
Compare
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks, LGTM. By the way, I created KAFKA-6751 since it seems like it might be useful to be able to update this config dynamically.
|
@hachikuji Thanks for the review. I will work on KAFKA-6751. |
Add a validation check to make sure max.connections.per.ip.overrides is configured when max.connections.per.ip is set zero. Also clean up the config description.
2 participants
Uh oh!
There was an error while loading. Please reload this page.